Skip to content

Conversation

@swap357
Copy link
Contributor

@swap357 swap357 commented Mar 31, 2025

No description provided.

@swap357 swap357 changed the title Gha/add llvmlite osx 64 wheel builder gha/add llvmlite osx 64 wheel builder Mar 31, 2025
@swap357 swap357 marked this pull request as ready for review March 31, 2025 23:20
@swap357 swap357 mentioned this pull request Mar 31, 2025
20 tasks
@swap357 swap357 requested a review from esc April 1, 2025 07:23
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So suggestions and a question

Co-authored-by: Emergency Self-Construct <esc@users.noreply.github.com>
@esc
Copy link
Member

esc commented Apr 7, 2025

@swap357 thank you for the updates, looks like there are some CI issues to be resolved.

@esc
Copy link
Member

esc commented Apr 8, 2025

@swap357 seems like the changes introduced in commit with ID 1840367 have created subsequent execution issues within the workflow.

@esc
Copy link
Member

esc commented Apr 9, 2025

@swap357 thank you for the fixes, I will review this again now.

@esc
Copy link
Member

esc commented Apr 9, 2025

Testing protocol and results:

a) merged this PR to esc/llvmlite@main: esc@0b15a08

b) used a GHA produced llvmdev from https://github.com/esc/llvmlite/actions/runs/14338724313

c) ran: https://github.com/esc/llvmlite/actions/runs/14354815563

This failed with:

Run actions/download-artifact@v4
  with:
    name: llvmdev_osx-64
    path: llvmdev_conda_packages
    run-id: 143387[2](https://github.com/esc/llvmlite/actions/runs/14354815563/job/40241729660#step:4:2)4313
    repository: esc/llvmlite
    github-token: ***
    merge-multiple: false
  env:
    LOCAL_LLVMDEV_ARTIFACT_PATH: /Users/runner/work/llvmlite/llvmlite/llvmdev_conda_packages
    FALLBACK_LLVMDEV_VERSION: 15
    CONDA_CHANNEL_NUMBA: numba/label/osx_wheel
    VALIDATION_PYTHON_VERSION: [3](https://github.com/esc/llvmlite/actions/runs/14354815563/job/40241729660#step:4:3).12
    ARTIFACT_RETENTION_DAYS: 7
    INPUT_RUN_POST: true
    CONDA: /Users/runner/miniconda3
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: llvmdev_osx-6[4](https://github.com/esc/llvmlite/actions/runs/14354815563/job/40241729660#step:4:4)
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

The error is that the llvmdev builder produces an artifact named llvmdev_for_wheel_osx-64 but the wheel builder is looking for an artifact called llvmdev_osx-64.

Note that the string inserted above llvmdev_osx-6[4] is actually a github bug, it sometimes does weird things to text that is copied into an issue. In fact all of the copied and pasted text is bogus, would suggest to look at the workflow run itself for an unadulterated variant.

esc
esc previously requested changes Apr 9, 2025
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I order to download the correct llvmdev artifact the correct artifact name must be used.

swap357 and others added 2 commits April 9, 2025 08:54
Co-authored-by: Emergency Self-Construct <esc@users.noreply.github.com>
@esc
Copy link
Member

esc commented Apr 9, 2025

Testing protocol for this PR.

a) merged this PR at esc@a3a3bfc

b) using the llvmdev artifact from https://github.com/esc/llvmlite/actions/runs/14338724313

c) launched https://github.com/esc/llvmlite/actions/runs/14360865808 to test this PR

@esc
Copy link
Member

esc commented Apr 9, 2025

Testing protocol for this PR.

a) merged this PR at esc@a3a3bfc

b) using the llvmdev artifact from https://github.com/esc/llvmlite/actions/runs/14338724313

c) launched https://github.com/esc/llvmlite/actions/runs/14360865808 to test this PR

it passed, this can now be used to generate an artifact for the numba_osx-64_wheel_builder.

Copy link
Contributor

@seibert seibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though we can't check the upload wheel part (since it depends on a secret, which is not available in a pull request) until after this is merged.

@seibert
Copy link
Contributor

seibert commented Apr 17, 2025

FYI: I'm going to need to dismiss @esc 's review because he's not available for a week, and I want to keep this PR moving. If there are additional changes needed, they will have to go into another PR.

@seibert seibert dismissed esc’s stale review April 17, 2025 19:59

I believe esc's requested changes have been made, but he's not available this week to update his approval.

@seibert seibert merged commit fb51877 into numba:main Apr 17, 2025
36 of 38 checks passed
@swap357 swap357 deleted the gha/add_llvmlite_osx-64_wheel_builder branch June 4, 2025 05:06
@swap357 swap357 restored the gha/add_llvmlite_osx-64_wheel_builder branch June 4, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants